[llvm-commits] [llvm] r48354 - in /llvm/trunk: lib/Transforms/Scalar/InstructionCombining.cpp test/Transforms/InstCombine/2008-03-13-IntToPtr.ll

[Bill Wendling]

On Mar 13, 2008, at 10:32 PM, Dale Johannesen wrote:

> On Mar 13, 2008, at 10:12 PM, Bill Wendling wrote:
>
>> Author: void
>> Date: Fri Mar 14 00:12:19 2008
>> New Revision: 48354
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=48354&view=rev
>> Log:
>> The inst combining of inttoptr into GEP with one index was using the
>> bit size of
>> the type instead of the byte size. This was causing troublesome mis-
>> compilations.
>
> Well done.
>
Thanks! :-)

>> True to form, this took 2 days to find and is a one-line fix. :-P
>
> That's fairly typical for wrong-compile bugs.  Good thing they don't
> evaluate us by counting lines of code, as they sometimes did in the
> bad old days:)
>
I never did understand why people used that metric. :-)

-bw