[llvm-commits] [llvm] r48325 - in /llvm/trunk: include/llvm/Function.h include/llvm/Instructions.h include/llvm/ParameterAttributes.h lib/VMCore/ParameterAttributes.cpp

[Chris Lattner]

Author: lattner
Date: Wed Mar 12 23:33:03 2008
New Revision: 48325

URL: http://llvm.org/viewvc/llvm-project?rev=48325&view=rev
Log:
Various improvements suggested by Duncan

Modified:
    llvm/trunk/include/llvm/Function.h
    llvm/trunk/include/llvm/Instructions.h
    llvm/trunk/include/llvm/ParameterAttributes.h
    llvm/trunk/lib/VMCore/ParameterAttributes.cpp

Modified: llvm/trunk/include/llvm/Function.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Function.h?rev=48325&r1=48324&r2=48325&view=diff

==============================================================================
--- llvm/trunk/include/llvm/Function.h (original)
+++ llvm/trunk/include/llvm/Function.h Wed Mar 12 23:33:03 2008
@@ -144,10 +144,12 @@
     SubclassData = (SubclassData & 1) | (CC << 1);
   }
   
-  /// getParamAttrs - Return the parameter attributes for this function.
+  /// getParamAttrs - Return the parameter attributes for this Function.
+  ///
   const PAListPtr &getParamAttrs() const { return ParamAttrs; }
 
   /// setParamAttrs - Set the parameter attributes for this Function.
+  ///
   void setParamAttrs(const PAListPtr &attrs) { ParamAttrs = attrs; }
 
   /// hasCollector/getCollector/setCollector/clearCollector - The name of the

Modified: llvm/trunk/include/llvm/Instructions.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Instructions.h?rev=48325&r1=48324&r2=48325&view=diff

==============================================================================
--- llvm/trunk/include/llvm/Instructions.h (original)
+++ llvm/trunk/include/llvm/Instructions.h Wed Mar 12 23:33:03 2008
@@ -926,11 +926,11 @@
     SubclassData = (SubclassData & 1) | (CC << 1);
   }
 
-  /// getParamAttrs - Return the PAListPtr for the parameter attributes of this
-  /// call.
+  /// getParamAttrs - Return the parameter attributes for this call.
+  ///
   const PAListPtr &getParamAttrs() const { return ParamAttrs; }
 
-  /// setParamAttrs - Sets the parameter attributes for this CallInst.
+  /// setParamAttrs - Sets the parameter attributes for this call.
   void setParamAttrs(const PAListPtr &Attrs) { ParamAttrs = Attrs; }
 
   /// @brief Determine whether the call or the callee has the given attribute.
@@ -1740,11 +1740,11 @@
     SubclassData = CC;
   }
 
-  /// getParamAttrs - Return the parameter attribute list for this invoke.
+  /// getParamAttrs - Return the parameter attributes for this invoke.
   ///
   const PAListPtr &getParamAttrs() const { return ParamAttrs; }
 
-  /// setParamAttrs - Set the parameter attribute list for this invoke.
+  /// setParamAttrs - Set the parameter attributes for this invoke.
   ///
   void setParamAttrs(const PAListPtr &Attrs) { ParamAttrs = Attrs; }
 

Modified: llvm/trunk/include/llvm/ParameterAttributes.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ParameterAttributes.h?rev=48325&r1=48324&r2=48325&view=diff

==============================================================================
--- llvm/trunk/include/llvm/ParameterAttributes.h (original)
+++ llvm/trunk/include/llvm/ParameterAttributes.h Wed Mar 12 23:33:03 2008
@@ -120,7 +120,7 @@
   static PAListPtr get(const ParamAttrsWithIndex *Attr, unsigned NumAttrs);
   
   /// get - Return a ParamAttr list with the parameters specified by the
-  /// consequtive random access iterator range.
+  /// consecutive random access iterator range.
   template <typename Iter>
   static PAListPtr get(const Iter &I, const Iter &E) {
     if (I == E) return PAListPtr();  // Empty list.
@@ -161,7 +161,7 @@
   /// least one parameter or for the return value.
   bool hasAttrSomewhere(ParameterAttributes Attr) const;
 
-  /// operator< - Provide an ordering for parameter attribute lists.
+  /// operator==/!= - Provide equality predicates.
   bool operator==(const PAListPtr &RHS) const { return PAList == RHS.PAList; }
   bool operator!=(const PAListPtr &RHS) const { return PAList != RHS.PAList; }
   

Modified: llvm/trunk/lib/VMCore/ParameterAttributes.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/VMCore/ParameterAttributes.cpp?rev=48325&r1=48324&r2=48325&view=diff

==============================================================================
--- llvm/trunk/lib/VMCore/ParameterAttributes.cpp (original)
+++ llvm/trunk/lib/VMCore/ParameterAttributes.cpp Wed Mar 12 23:33:03 2008
@@ -77,7 +77,7 @@
 class ParamAttributeListImpl : public FoldingSetNode {
   unsigned RefCount;
   
-  // ParamAttrsList is uniqued, these should not be publicly available
+  // ParamAttrsList is uniqued, these should not be publicly available.
   void operator=(const ParamAttributeListImpl &); // Do not implement
   ParamAttributeListImpl(const ParamAttributeListImpl &); // Do not implement
   ~ParamAttributeListImpl();                        // Private implementation