[llvm-commits] [llvm] r48226 - in /llvm/trunk: include/llvm/PassManager.h lib/VMCore/PassManager.cpp

[Dan Gohman]

Author: djg
Date: Tue Mar 11 11:41:42 2008
New Revision: 48226

URL: http://llvm.org/viewvc/llvm-project?rev=48226&view=rev
Log:
Give PassManager and FunctionPassManager a common base class, with
add(Pass *) as a pure virtual member function. This will allow all
the various addPassesTo* functions in LLVM to avoid hard-coding what
type of PassManager is used. 

Modified:
    llvm/trunk/include/llvm/PassManager.h
    llvm/trunk/lib/VMCore/PassManager.cpp

Modified: llvm/trunk/include/llvm/PassManager.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/PassManager.h?rev=48226&r1=48225&r2=48226&view=diff

==============================================================================
--- llvm/trunk/include/llvm/PassManager.h (original)
+++ llvm/trunk/include/llvm/PassManager.h Tue Mar 11 11:41:42 2008
@@ -29,8 +29,22 @@
 class PassManagerImpl;
 class FunctionPassManagerImpl;
 
+/// PassManagerBase - An abstract interface to allow code to add passes to
+/// a pass manager without having to hard-code what kind of pass manager
+/// it is.
+class PassManagerBase {
+public:
+  virtual ~PassManagerBase();
+
+  /// add - Add a pass to the queue of passes to run.  This passes ownership of
+  /// the Pass to the PassManager.  When the PassManager is destroyed, the pass
+  /// will be destroyed as well, so there is no need to delete the pass.  This
+  /// implies that all passes MUST be allocated with 'new'.
+  virtual void add(Pass *P) = 0;
+};
+
 /// PassManager manages ModulePassManagers
-class PassManager {
+class PassManager : public PassManagerBase {
 public:
 
   PassManager();
@@ -54,7 +68,7 @@
 };
 
 /// FunctionPassManager manages FunctionPasses and BasicBlockPassManagers.
-class FunctionPassManager {
+class FunctionPassManager : public PassManagerBase {
 public:
   /// FunctionPassManager ctor - This initializes the pass manager.  It needs,
   /// but does not take ownership of, the specified module provider.

Modified: llvm/trunk/lib/VMCore/PassManager.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/VMCore/PassManager.cpp?rev=48226&r1=48225&r2=48226&view=diff

==============================================================================
--- llvm/trunk/lib/VMCore/PassManager.cpp (original)
+++ llvm/trunk/lib/VMCore/PassManager.cpp Tue Mar 11 11:41:42 2008
@@ -1531,4 +1531,4 @@
   BBP->add(this);
 }
 
-
+PassManagerBase::~PassManagerBase() {}