[llvm-commits] [llvm] r47676 - /llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeTypesSplit.cpp

[Duncan Sands]

Author: baldrick
Date: Wed Feb 27 11:39:13 2008
New Revision: 47676

URL: http://llvm.org/viewvc/llvm-project?rev=47676&view=rev
Log:
Add a FIXME about the VECTOR_SHUFFLE evil hack.

Modified:
    llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeTypesSplit.cpp

Modified: llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeTypesSplit.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeTypesSplit.cpp?rev=47676&r1=47675&r2=47676&view=diff

==============================================================================
--- llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeTypesSplit.cpp (original)
+++ llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeTypesSplit.cpp Wed Feb 27 11:39:13 2008
@@ -547,6 +547,8 @@
 
     // If the element type is not legal, find a larger legal type to use for
     // the BUILD_VECTOR operands.  This is an ugly hack, but seems to work!
+    // FIXME: The real solution is to change VECTOR_SHUFFLE into a variadic
+    // node where the shuffle mask is a list of integer operands, #2 .. #2+n.
     for (MVT::SimpleValueType OpVT = EltVT; OpVT <= MVT::LAST_INTEGER_VALUETYPE;
          // Integer values types are consecutively numbered.  Exploit this.
          OpVT = MVT::SimpleValueType(OpVT + 1)) {