[llvm-commits] [llvm] r47511 - in /llvm/trunk: include/llvm/Instructions.h lib/VMCore/AsmWriter.cpp

Devang Patel dpatel at apple.com
Fri Feb 22 16:47:00 PST 2008


Author: dpatel
Date: Fri Feb 22 18:47:00 2008
New Revision: 47511

URL: http://llvm.org/viewvc/llvm-project?rev=47511&view=rev
Log:
Use dyn_cast instead of isa + cast.

Modified:
    llvm/trunk/include/llvm/Instructions.h
    llvm/trunk/lib/VMCore/AsmWriter.cpp

Modified: llvm/trunk/include/llvm/Instructions.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Instructions.h?rev=47511&r1=47510&r2=47511&view=diff

==============================================================================
--- llvm/trunk/include/llvm/Instructions.h (original)
+++ llvm/trunk/include/llvm/Instructions.h Fri Feb 22 18:47:00 2008
@@ -2375,7 +2375,11 @@
     return getOperand(0);
   }
 
-  unsigned getIndex() {
+  inline unsigned getIndex() {
+    return Idx;
+  }
+
+  inline const unsigned getIndex() const {
     return Idx;
   }
 

Modified: llvm/trunk/lib/VMCore/AsmWriter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/VMCore/AsmWriter.cpp?rev=47511&r1=47510&r2=47511&view=diff

==============================================================================
--- llvm/trunk/lib/VMCore/AsmWriter.cpp (original)
+++ llvm/trunk/lib/VMCore/AsmWriter.cpp Fri Feb 22 18:47:00 2008
@@ -1291,7 +1291,7 @@
       writeOperand(I.getOperand(op  ), false); Out << ',';
       writeOperand(I.getOperand(op+1), false); Out << " ]";
     }
-  } else if (isa<GetResultInst>(I)) {
+  } else if (const GetResultInst *GRI = dyn_cast<GetResultInst>(&I)) {
     const StructType *STy = cast<StructType>(I.getOperand(0)->getType());
     unsigned NumElems = STy->getNumElements();
     Out << " {";
@@ -1303,7 +1303,7 @@
     }
     Out << " }";
     writeOperand(I.getOperand(0), false);
-    Out << ", " << cast<GetResultInst>(I).getIndex();
+    Out << ", " << GRI->getIndex();
   } else if (isa<ReturnInst>(I) && !Operand) {
     Out << " void";
   } else if (const CallInst *CI = dyn_cast<CallInst>(&I)) {





More information about the llvm-commits mailing list