[llvm-commits] [llvm] r47484 - in /llvm/trunk: include/llvm/Function.h include/llvm/Instructions.h include/llvm/ParameterAttributes.h include/llvm/Support/CallSite.h include/llvm/Target/TargetLowering.h lib/AsmParser/llvmAsmParser.y lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp lib/VMCore/Function.cpp lib/VMCore/Instructions.cpp

[Chris Lattner]

On Feb 22, 2008, at 10:36 AM, Dale Johannesen wrote:

>> Does this apply just to byval, or to all arguments?  If just byval,
>> howabout "getByvalParamAlignment" or something.  likewise for call/
>> invoke/callsite/paramattr.  If this applies to any argument, then no
>> rename is needed obviously :)
>
> It only appears on ByVal at the moment, but all the infrastructure is
> there to support other usage.  I have some preference for leaving the
> names generic to make this clearer, but I see no need for other usage,
> so I don't feel strongly about it.

I think it makes sense to be able to specify alignment for a scalar  
argument as well, so I think keeping it generic makes sense.  I don't  
know if we'll ever use it, but it doesn't hurt to keep the door open.

Thanks Dale!

-Chris