[llvm-commits] [llvm] r47425 - in /llvm/trunk: lib/VMCore/Value.cpp lib/VMCore/Verifier.cpp test/Assembler/2008-02-20-MultipleReturnValue.ll

Devang Patel dpatel at apple.com
Thu Feb 21 14:24:36 PST 2008


Fixed.

On Feb 20, 2008, at 9:19 PM, Chris Lattner wrote:

>> URL: http://llvm.org/viewvc/llvm-project?rev=47425&view=rev
>> Log:
>> Let invoke return aggregate value.
>> -  if (isa<CallInst>(this))
>> +  if (isa<CallInst>(this) || isa<InvokeInst>(this))
>>    assert((Ty->isFirstClassType() || Ty == Type::VoidTy ||
>>            isa<OpaqueType>(ty) || Ty->getTypeID() ==
>> Type::StructTyID) &&
>
> Please use isa<StructType>(Ty) instead of poking getTypeID().
>
>> +++ llvm/trunk/lib/VMCore/Verifier.cpp Wed Feb 20 20:14:01 2008
>> @@ -1072,7 +1072,8 @@
>>  // Check that the return value of the instruction is either void
>> or a legal
>>  // value type.
>>  Assert1(I.getType() == Type::VoidTy || I.getType()-
>>> isFirstClassType()
>> -          || (isa<CallInst>(I) && I.getType()->getTypeID() ==
>> Type::StructTyID),
>> +          || ((isa<CallInst>(I) || isa<InvokeInst>(I))
>> +              && I.getType()->getTypeID() == Type::StructTyID),
>
> Likewise.
>
> Thanks Devang,
>
> -Chris
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

-
Devang






More information about the llvm-commits mailing list