[llvm-commits] [llvm] r47086 - in /llvm/trunk: include/llvm/ADT/APInt.h lib/Support/APInt.cpp

Bill Wendling isanbard at gmail.com
Sun Feb 17 22:25:39 PST 2008


Dan submitted a fix last week.

-bw

On Feb 17, 2008, at 2:16 PM, Evan Cheng wrote:

> Ping. Is this fixed? Does it affect build with -Werror set?
>
> Evan
>
> On Feb 13, 2008, at 5:22 PM, Bill Wendling wrote:
>
>> Hi Dan,
>>
>>> +uint32_t APInt::countTrailingOnes() const {
>>> +  if (isSingleWord())
>>> +    return std::min(uint32_t(CountTrailingOnes_64(VAL)), BitWidth);
>>> +  uint32_t Count = 0;
>>> +  uint32_t i = 0;
>>> +  for (; i < getNumWords() && pVal[i] == -1; ++i)
>>
>> This compare leads to this warning:
>>
>> llvm[1]: Compiling APInt.cpp for Debug build
>> /Volumes/Gir/devel/llvm/llvm.src/lib/Support/APInt.cpp: In member
>> function 'uint32_t llvm::APInt::countTrailingOnes() const':
>> /Volumes/Gir/devel/llvm/llvm.src/lib/Support/APInt.cpp:821: warning:
>> comparison between signed and unsigned integer expressions
>>
>> Could you take a look at it please?
>>
>> -bw
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits




More information about the llvm-commits mailing list