[llvm-commits] [llvm] r46949 - in /llvm/trunk/lib/Target: TargetSelectionDAG.td X86/README-SSE.txt X86/X86ISelLowering.cpp X86/X86ISelLowering.h X86/X86InstrSSE.td

[Nate Begeman]

On Feb 12, 2008, at 12:00 AM, Evan Cheng wrote:

>
> On Feb 10, 2008, at 8:19 PM, Nate Begeman wrote:
>
>>
>> +
>> +  if (Subtarget->hasSSE41()) {
>> ...
> ...
>>
>> +    if (Subtarget->is64Bit()) {
>> +      setOperationAction(ISD::INSERT_VECTOR_ELT,  MVT::v2i64,  
>> Legal);
>> +      setOperationAction(ISD::INSERT_VECTOR_ELT,  MVT::v2f64,  
>> Legal);
>> +
>> +      setOperationAction(ISD::EXTRACT_VECTOR_ELT, MVT::v2i64,  
>> Legal);
>> +      setOperationAction(ISD::EXTRACT_VECTOR_ELT, MVT::v2f64,  
>> Legal);
>> +    }
>> +  }
>
> I don't see the corresponding patterns? This breaks X86/illegal-
> insert.ll on SSE4 capable machines. I am going to change them from
> 'legal' to 'custom' for now. Please fix if that's not right.
>
> Thanks,
>
> Evan

Fix committed.

Nate