[llvm-commits] [llvm] r46350 - /llvm/trunk/include/llvm/CodeGen/MachineFrameInfo.h

[Evan Cheng]

Ugh, really??

Evan
On Jan 24, 2008, at 11:29 PM, Chris Lattner wrote:

> Author: lattner
> Date: Fri Jan 25 01:29:34 2008
> New Revision: 46350
>
> URL: http://llvm.org/viewvc/llvm-project?rev=46350&view=rev
> Log:
> move this field back.  Moving the field causes miscompilations (!)  
> of voronoi and others.
>
> Modified:
>    llvm/trunk/include/llvm/CodeGen/MachineFrameInfo.h
>
> Modified: llvm/trunk/include/llvm/CodeGen/MachineFrameInfo.h
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/CodeGen/MachineFrameInfo.h?rev=46350&r1=46349&r2=46350&view=diff
>
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> ======================================================================
> --- llvm/trunk/include/llvm/CodeGen/MachineFrameInfo.h (original)
> +++ llvm/trunk/include/llvm/CodeGen/MachineFrameInfo.h Fri Jan 25  
> 01:29:34 2008
> @@ -83,17 +83,17 @@
>     // Alignment - The required alignment of this stack slot.
>     unsigned Alignment;
>
> +    // SPOffset - The offset of this object from the stack pointer  
> on entry to
> +    // the function.  This field has no meaning for a variable  
> sized element.
> +    int64_t SPOffset;
> +
>     // isImmutable - If true, the value of the stack object is set  
> before
>     // entering the function and is not modified inside the  
> function. By
>     // default, fixed objects are immutable unless marked otherwise.
>     bool isImmutable;
>
> -    // SPOffset - The offset of this object from the stack pointer  
> on entry to
> -    // the function.  This field has no meaning for a variable  
> sized element.
> -    int64_t SPOffset;
> -
>     StackObject(uint64_t Sz, unsigned Al, int64_t SP, bool IM = false)
> -      : Size(Sz), Alignment(Al), isImmutable(IM), SPOffset(SP) {}
> +      : Size(Sz), Alignment(Al), SPOffset(SP), isImmutable(IM) {}
>   };
>
>   /// Objects - The list of stack objects allocated...
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits