[llvm-commits] [llvm] r46228 - /llvm/trunk/include/llvm/ADT/ImmutableSet.h

Ted Kremenek kremenek at apple.com
Mon Jan 21 14:51:44 PST 2008


Author: kremenek
Date: Mon Jan 21 16:51:35 2008
New Revision: 46228

URL: http://llvm.org/viewvc/llvm-project?rev=46228&view=rev
Log:
Moved method call within a conditional branch because its effects will
be ignored on the false branch.

Modified:
    llvm/trunk/include/llvm/ADT/ImmutableSet.h

Modified: llvm/trunk/include/llvm/ADT/ImmutableSet.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ADT/ImmutableSet.h?rev=46228&r1=46227&r2=46228&view=diff

==============================================================================
--- llvm/trunk/include/llvm/ADT/ImmutableSet.h (original)
+++ llvm/trunk/include/llvm/ADT/ImmutableSet.h Mon Jan 21 16:51:35 2008
@@ -219,9 +219,9 @@
     //  of the last item hash and the the next item.
     
     unsigned X = ID.ComputeHash();
-    ID.clear();
     
     if (R) {
+      ID.clear();
       ID.AddInteger(X);
       ID.AddInteger(R->ComputeHash());
       X = ID.ComputeHash();





More information about the llvm-commits mailing list