[llvm-commits] [llvm] r45850 - /llvm/trunk/lib/VMCore/Verifier.cpp

[Chris Lattner]

On Jan 10, 2008, at 11:45 PM, Evan Cheng wrote:

>
> On Jan 10, 2008, at 10:43 PM, Duncan Sands wrote:
>
>> Hi Evan,
>>
>>> Allow parameter attributes on varargs function parameters.
>>
>> there are some issues that need to be fixed:
>> (1) the asm parser drops parameter attributes specified on the  
>> varargs
>> part of a call/invoke;
>> (2) when the DAE pass drops varargs call arguments, the parameter
>> attributes need to be trimmed, since otherwise you can have  
>> attributes
>> that don't correspond to a call argument any more;
>> (3) when instcombine resolves calls to a bitcast of a function into
>> a direct call, then parameter attributes will be lost on any varargs
>> part of a call.
>>
>> You need this for byval support, right?
>
> Yep.

Evan, if you send me a testcase for the DAE problem, I'll fix it.  I'm  
taking a look at argpromote now to see if it needs to be tweaked.

-Chris