[llvm-commits] [llvm] r45626 - /llvm/trunk/lib/Target/X86/X86InstrInfo.cpp

[Bill Wendling]

On Jan 6, 2008, at 10:20 PM, Chris Lattner wrote:
> On Jan 6, 2008, at 6:45 PM, Evan Cheng wrote:
>
>> By the way. This check is still not quite right.
>>
>>       // Loads from stubs of global addresses are side effect free.
>>      if (Reg != 0 && MRegisterInfo::isVirtualRegister(Reg) &&
>>
>> In dynamic-no-pic mode, Reg can be 0. So it should be Reg == 0 || ...
>
> Why is this code even looking at that operand?
>
Um...because it was given to me in the feedback for my patch. :-)

Actually on thinking about it now, it shouldn't matter. I'll remove it.

-bw