[llvm-commits] [llvm] r45676 - in /llvm/trunk: include/llvm/CallingConv.h include/llvm/CodeGen/LinkAllCodegenComponents.h lib/CodeGen/OcamlCollector.cpp test/CodeGen/Generic/GC/frame_size.ll test/CodeGen/Generic/GC/simple_ocaml.ll

[Chris Lattner]

On Jan 6, 2008, at 6:31 PM, Gordon Henriksen wrote:
> URL: http://llvm.org/viewvc/llvm-project?rev=45676&view=rev
> Log:
> Setting GlobalDirective in TargetAsmInfo by default rather than
> providing a misleading facility. It's used once in the MIPS backend
> and hardcoded as "\t.globl\t" everywhere else.

Hi Gordon, this commit message doesn't line up.

> =
> =
> =
> =
> =
> =
> =
> =
> ======================================================================
> --- llvm/trunk/include/llvm/CallingConv.h (original)
> +++ llvm/trunk/include/llvm/CallingConv.h Sun Jan  6 20:31:11 2008
> @@ -57,7 +57,12 @@
>     /// X86_FastCall - 'fast' analog of X86_StdCall. Passes first  
> two arguments
>     /// in ECX:EDX registers, others - via stack. Callee is  
> responsible for
>     /// stack cleaning.
> -    X86_FastCall = 65
> +    X86_FastCall = 65,
> +
> +    /// X86_Ocaml - This is a weird ABI used by Objective Caml.  
> Formally, it
> +    /// supports only one to six integer/address arguments, all in- 
> reg. It also
> +    /// supports tail call emission.
> +    X86_Ocaml = 66

This looks dead, accidental commit?

> +#include "llvm/CodeGen/Collectors.h"
> +#include "llvm/ADT/DenseMap.h"
> +#include "llvm/CodeGen/AsmPrinter.h"
> +#include "llvm/CodeGen/Collector.h"
> +#include "llvm/CodeGen/CollectorMetadata.h"
> +#include "llvm/Function.h"
> +#include "llvm/Module.h"

Please try to prune down the #includes to a minimum, Function.h can  
certainly go, if others can too, please remove them as well.

> +#include "llvm/Target/TargetData.h"
> +#include "llvm/Target/TargetMachine.h"
> +#include <ctype.h>

How about <cctype> ?

Otherwise, looks great :)

-Chris