[llvm-commits] [llvm] r45131 - in /llvm/trunk: include/llvm/AutoUpgrade.h include/llvm/IntrinsicsX86.td lib/Bitcode/Reader/BitcodeReader.cpp lib/VMCore/AutoUpgrade.cpp test/Bitcode/sse2_movl_dq.ll test/Bitcode/sse2_movl_dq.ll.bc

[Chris Lattner]

>>> +++ llvm/trunk/include/llvm/IntrinsicsX86.td Mon Dec 17 16:33:23  
>>> 2007
>>> @@ -460,6 +460,8 @@
>>>   def int_x86_sse2_packuswb_128 :
>>> GCCBuiltin<"__builtin_ia32_packuswb128">,
>>>               Intrinsic<[llvm_v8i16_ty, llvm_v8i16_ty,
>>>                          llvm_v8i16_ty], [IntrNoMem]>;
>>> +  def int_x86_sse2_movl_dq : GCCBuiltin<"__builtin_ia32_movqv4si">,
>>> +              Intrinsic<[llvm_v4i32_ty, llvm_v4i32_ty],
>>> [IntrNoMem]>;
>>
>> I don't think this is need anymore?  The intrinsic can't get past the
>> bc/ll readers now.
>
> AutoUpgrade.cpp has to recognize it somehow?
>
>      switch(F->getIntrinsicID()) {
>      case Intrinsic::x86_sse2_movl_dq: {
> 	...
>      }

if (!strcmp(F->getNameStart(), "llvm.foo")) ?

The "nice" thing about this is that it hides the upgrading grossness  
in one place instead of leaving a turd in the public .td file.

-Chris