[llvm-commits] llvm on ppc/linux

[Dale Johannesen]

On Nov 12, 2007, at 3:18 PM, Eric Christopher wrote:

>>
>> However proper that may be, it will not work.  llvm-gcc-4.0 is based
>> on
>> Apple's 4.0, and ADJUST_FIELD_ALIGN has 3 arguments.
>>
>
> Sure, but you can simply ignore the 3rd argument.

Create still another version of it, you mean.

>> I am testing Nick's patch on ppc32 Darwin and plan to check in if it
>> looks like that was not broken.
>
> I would very much suggest that you not check in the 32-bit linux part,
> as it
> isn't the correct fix.

This community is less obsessed than gcc'ers about finding "the  
correct" fix, which speeds things up tremendously.  In this case  
ppc32 Linux didn't work before and does now; that's enough of a gain  
to check something in IMO.  If you want to improve it, you can.

That said, it's true TARGET_ALIGN_MAC68K should be always false on  
Linux, and the macro could be simplified.