[llvm-commits] [llvm-gcc-4.2] r43656 - in /llvm-gcc-4.2/trunk/gcc: Makefile.in c-common.c config/rs6000/rs6000.c configure configure.ac cp/except.c passes.c varasm.c

[Dale Johannesen]

On Nov 3, 2007, at 2:11 AM, Bill Wendling wrote:

> On Nov 3, 2007, at 1:15 AM, Duncan Sands wrote:
>
>>> - Use "-Wno-overlength-strings" to silence a warning during
>>>   bootstrapping.
>>
>> Because the warning was bogus?
>>
> Depends on what you mean by bogus. :-)
>
> Yes, the strings were over the max allowed by the standard, but it is
> in gcc.c, so I assume (foolishly, I know ;-) ) that they know what
> they're doing.

Those long strings have been there as long as I can remember.
You'll see -Werror is disabled for that file in the 4.0 Makefile.in.
For 4.2 they seem to have changed the mechanism...disallowing
this particular warning seems in principle like the right way to go.

> Also notice that the if-then in the shell is checking:
>
> 	test $ac_cv_prog_cc_w_no_overlength_strings = yes
>
> but it wasn't adding that to the strict1_warn variable. So this is
> basically making it equal to what's in Apple's GCC 4.2.
>
> -bw
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits