[llvm-commits] [llvm] r43359 - in /llvm/trunk/lib/CodeGen: BranchFolding.cpp README.txt

[Bill Wendling]

Author: void
Date: Thu Oct 25 14:49:32 2007
New Revision: 43359

URL: http://llvm.org/viewvc/llvm-project?rev=43359&view=rev
Log:
Changed XXX to FIXME, and added comment to the README file

Modified:
    llvm/trunk/lib/CodeGen/BranchFolding.cpp
    llvm/trunk/lib/CodeGen/README.txt

Modified: llvm/trunk/lib/CodeGen/BranchFolding.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/BranchFolding.cpp?rev=43359&r1=43358&r2=43359&view=diff

==============================================================================
--- llvm/trunk/lib/CodeGen/BranchFolding.cpp (original)
+++ llvm/trunk/lib/CodeGen/BranchFolding.cpp Thu Oct 25 14:49:32 2007
@@ -272,7 +272,7 @@
   while (I1 != MBB1->begin() && I2 != MBB2->begin()) {
     --I1; --I2;
     if (!I1->isIdenticalTo(I2) || 
-        // XXX: This check is dubious. It's used to get around a problem where
+        // FIXME: This check is dubious. It's used to get around a problem where
         // people incorrectly expect inline asm directives to remain in the same
         // relative order. This is untenable because normal compiler
         // optimizations (like this one) may reorder and/or merge these

Modified: llvm/trunk/lib/CodeGen/README.txt
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/README.txt?rev=43359&r1=43358&r2=43359&view=diff

==============================================================================
--- llvm/trunk/lib/CodeGen/README.txt (original)
+++ llvm/trunk/lib/CodeGen/README.txt Thu Oct 25 14:49:32 2007
@@ -179,3 +179,11 @@
 
 The ocaml frametable structure supports liveness information. It would be good
 to support it.
+
+//===---------------------------------------------------------------------===//
+
+The FIXME in ComputeCommonTailLength in BranchFolding.cpp needs to be
+revisited. The check is there to work around a misuse of directives in inline
+assembly.
+
+//===---------------------------------------------------------------------===//