[llvm-commits] [llvm] r43141 - in /llvm/trunk: lib/Transforms/IPO/DeadArgumentElimination.cpp test/Transforms/DeadArgElim/2007-10-18-VarargsReturn.ll

[Chris Lattner]

Author: lattner
Date: Thu Oct 18 13:49:29 2007
New Revision: 43141

URL: http://llvm.org/viewvc/llvm-project?rev=43141&view=rev
Log:
Fix PR1735 and Transforms/DeadArgElim/2007-10-18-VarargsReturn.ll by
fixing some obviously broken code :(

Added:
    llvm/trunk/test/Transforms/DeadArgElim/2007-10-18-VarargsReturn.ll
Modified:
    llvm/trunk/lib/Transforms/IPO/DeadArgumentElimination.cpp

Modified: llvm/trunk/lib/Transforms/IPO/DeadArgumentElimination.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/IPO/DeadArgumentElimination.cpp?rev=43141&r1=43140&r2=43141&view=diff

==============================================================================
--- llvm/trunk/lib/Transforms/IPO/DeadArgumentElimination.cpp (original)
+++ llvm/trunk/lib/Transforms/IPO/DeadArgumentElimination.cpp Thu Oct 18 13:49:29 2007
@@ -168,7 +168,7 @@
     CallSite CS = CallSite::get(Fn.use_back());
     Instruction *Call = CS.getInstruction();
     
-    // Loop over the operands, dropping extraneous ones at the end of the list.
+    // Pass all the same arguments.
     Args.assign(CS.arg_begin(), CS.arg_begin()+NumArgs);
     
     Instruction *New;
@@ -185,13 +185,13 @@
     Args.clear();
     
     if (!Call->use_empty())
-      Call->replaceAllUsesWith(Constant::getNullValue(Call->getType()));
+      Call->replaceAllUsesWith(New);
     
     New->takeName(Call);
     
     // Finally, remove the old call from the program, reducing the use-count of
     // F.
-    Call->getParent()->getInstList().erase(Call);
+    Call->eraseFromParent();
   }
   
   // Since we have now created the new function, splice the body of the old

Added: llvm/trunk/test/Transforms/DeadArgElim/2007-10-18-VarargsReturn.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/DeadArgElim/2007-10-18-VarargsReturn.ll?rev=43141&view=auto

==============================================================================
--- llvm/trunk/test/Transforms/DeadArgElim/2007-10-18-VarargsReturn.ll (added)
+++ llvm/trunk/test/Transforms/DeadArgElim/2007-10-18-VarargsReturn.ll Thu Oct 18 13:49:29 2007
@@ -0,0 +1,12 @@
+; RUN: llvm-as < %s | opt -deadargelim | llvm-dis | not grep {ret i32 0}
+; PR1735
+
+define internal i32 @test(i32 %A, ...) { 
+	ret i32 %A
+}
+
+define i32 @foo() {
+	%A = call i32(i32, ...)* @test(i32 1)
+	ret i32 %A
+}
+