[llvm-commits] darwin x86 make check failures

[Tanya Lattner]

Thanks Dale & Dan!

The second one passes for me now.

-Tanya

On Oct 12, 2007, at 1:48 PM, Dan Gohman wrote:

>>> Anyone want to claim them? ;)
>>
>> I confirm this is happening, but it was not happening until I did a
>> checkout.
>
> They're both due to 42908.
>
>> 2006-10-19-SwitchUnnecessaryBranching.ll was introduced by the change
>> in label names.
>> It looks like there was an attempt to fix it once, so it's probably
>> OS dependent.  On darwin
>> it's trying to match LBB1__main (2 underscores) with BB1_main (1
>> underscore).
>
> I'll add a target triple to make this one behave consistently.
>
>> The other one is failing doing
>> grep -i ST | not grep {fadd\\|fsub\\|fdiv\\|fmul}
>>
>> There are no lines that match ST (correctly IMO).  I would expect
>> "not grep" to succeed
>> on null input, but apparently it doesn't.  It's not obvious what the
>> grep for ST is trying to
>> do, but I doubt this is still testing what it was supposed to test.
>
> I just submitted a fix for this one. I believe it now tests what
> it's supposed to.
>
> Dan
>
> -- 
> Dan Gohman, Cray Inc.
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits