[llvm-commits] [llvm] r42908 - in /llvm/trunk: include/llvm/CodeGen/ lib/CodeGen/ lib/Target/ARM/ lib/Target/Alpha/ lib/Target/IA64/ lib/Target/Mips/ lib/Target/PowerPC/ lib/Target/Sparc/ lib/Target/X86/ test/CodeGen/X86/

[Dale Johannesen]

It would be nice if names were only constructed in one place....

On Oct 12, 2007, at 2:52 PM, Bill Wendling wrote:

> Hi Dan,
>
> With your changes, I'm getting this during bootrapping of llvm-gcc:
>
> /var/tmp//cc8ddbeM.s:unknown:Undefined local symbol  
> L0__set_6__run_routines
> /var/tmp//cc8ddbeM.s:unknown:Undefined local symbol  
> L0__set_9__run_routines
> /var/tmp//cc8ddbeM.s:unknown:Undefined local symbol  
> L0__set_7__run_routines
> /var/tmp//cc8ddbeM.s:unknown:Undefined local symbol  
> L0__set_10__run_routines
> /var/tmp//cc8ddbeM.s:unknown:Undefined local symbol  
> L0__set_8__run_routines
> /var/tmp//cc8ddbeM.s:unknown:Undefined local symbol  
> L0__set_11__run_routines
>
> This is during the build of crt3.o. I think it's due to this part  
> of the patch.
>
>> --- llvm/trunk/lib/CodeGen/AsmPrinter.cpp (original)
>> +++ llvm/trunk/lib/CodeGen/AsmPrinter.cpp Fri Oct 12 09:53:36 2007
>> @@ -306,15 +306,15 @@
>>        // If we're emitting non-PIC code, then emit the entries as  
>> direct
>>        // references to the target basic blocks.
>>        if (!EmittedSets.empty()) {
>> -        O << TAI->getPrivateGlobalPrefix() << getFunctionNumber()
>> -          << '_' << i << "_set_" << JTBBs[ii]->getNumber();
>> +        O << TAI->getPrivateGlobalPrefix() << i
>> +          << '_' << "_set_" << JTBBs[ii]->getNumber() << '_' <<  
>> CurrentFnName;
>
> In particular, this:
>
>      << '_' << "_set_" ...
>
> should probably be:
>
>     << "_set_"
>
> What do you think?
>
> -bw
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits