[llvm-commits] RFC: internal label names

Evan Cheng evan.cheng at apple.com
Thu Oct 11 18:30:29 PDT 2007


On Oct 10, 2007, at 4:46 PM, Chris Lattner wrote:

>
> On Oct 10, 2007, at 12:41 PM, Dan Gohman wrote:
>
>>> 1. if the name is short, print it as you propose.
>>> 2. if the name is long, print it with a number and optionally with a
>>> subset of the name (last 10 chars?)
>>>
>>> This could be implemented by just adding a new ivar like
>>> CurrentFunctionName that holds this.
>>
>> I think that is over complex :). C++ mangled names are ok with me
>> here,
>> but if they're unpleasant for others that's fine.
>
> Ok, if you can convince Evan, I'm fine with it "ready: fight!"

Making me out to be a bad guy when in reality Chris is the picky  
one. :-)

How about you check it in? I will ask it to be backed out if the long  
labels bug me.

Evan

>
>
> ;-)
>
> -Chris
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits




More information about the llvm-commits mailing list