[llvm-commits] [llvm] r42269 - in /llvm/trunk: include/llvm/ADT/DenseMap.h include/llvm/ADT/SparseBitVector.h lib/Analysis/IPA/Andersens.cpp

[Duncan Sands]

Hi DannyB,

> @@ -287,6 +286,14 @@
>      }
>      BecameZero = allzero;
>    }
> +  // Get a hash value for this element;
> +  uint64_t getHashValue() const {

shouldn't there be a blank line before the added lines?

> +// The Offline constraint graph optimization portion includes offline variable

The Offline -> The offline

> +// substitution algorithms intended to pointer and location equivalences.

Does not parse!

> +    // graph.  Due to various optimizations, not always the case that there is a

not always the case -> it is not always the case

> +      // True if our ponits-to set is in the Set2PEClass map

ponits-to -> points-to

> +      // True if our node has no indirect constraints (Complex or otherwise)

Complex -> complex

> +      // their arg nodes, which must be kept at the same position relative to
> +      // their base function node.
> +      // kept at the same position relative to their base function node.

Looks like this last line shouldn't be there.

Ciao,

Duncan.