[llvm-commits] [llvm] r41858 - in /llvm/trunk: include/llvm/ADT/ lib/AsmParser/ lib/Bitcode/Reader/ lib/Bitcode/Writer/ lib/CodeGen/ lib/CodeGen/SelectionDAG/ lib/Support/ lib/Target/CBackend/ lib/Target/MSIL/ lib/Target/X86/ lib/VMCore/ tools/llvm2cpp/

[Chris Lattner]

On Sep 11, 2007, at 4:41 PM, Dale Johannesen wrote:

>
>>> +/// Treat api as containing the bits of a floating point number.
>>> Currently
>>> +/// we infer the floating point type from the size of the APInt.
>>> FIXME: This
>>> +/// breaks when we get to PPC128 and IEEE128 (but both cannot
>>> exist in the
>>> +/// same compile...)
>>
>> They can't both exist in the same module, but this method won't know
>> which it is getting without some context passed in.
>
> Or globally visible, or calling a target hook.  Yeah, I know.  I
> considered
> having the APInt's be 128 bits always and passing the type in  
> parallel,
> but that leads to much uglier (& less efficient) code....I suppose we
> could
> allocate an extra bit for one of them.  Ugh.

It think it would be better to add an extra argument to the function,  
indicating what format it is in.

-Chris