[llvm-commits] [llvm] r41861 - /llvm/trunk/utils/TableGen/DAGISelEmitter.cpp

Evan Cheng evan.cheng at apple.com
Tue Sep 11 12:52:19 PDT 2007


Author: evancheng
Date: Tue Sep 11 14:52:18 2007
New Revision: 41861

URL: http://llvm.org/viewvc/llvm-project?rev=41861&view=rev
Log:
Allow set operators with multiple destinations, i.e. (set x, y, (op a, b)).

Modified:
    llvm/trunk/utils/TableGen/DAGISelEmitter.cpp

Modified: llvm/trunk/utils/TableGen/DAGISelEmitter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/TableGen/DAGISelEmitter.cpp?rev=41861&r1=41860&r2=41861&view=diff

==============================================================================
--- llvm/trunk/utils/TableGen/DAGISelEmitter.cpp (original)
+++ llvm/trunk/utils/TableGen/DAGISelEmitter.cpp Tue Sep 11 14:52:18 2007
@@ -676,14 +676,20 @@
   
   // special handling for set, which isn't really an SDNode.
   if (getOperator()->getName() == "set") {
-    assert (getNumChildren() == 2 && "Only handle 2 operand set's for now!");
-    bool MadeChange = getChild(0)->ApplyTypeConstraints(TP, NotRegisters);
-    MadeChange |= getChild(1)->ApplyTypeConstraints(TP, NotRegisters);
-    
-    // Types of operands must match.
-    MadeChange |= getChild(0)->UpdateNodeType(getChild(1)->getExtTypes(), TP);
-    MadeChange |= getChild(1)->UpdateNodeType(getChild(0)->getExtTypes(), TP);
-    MadeChange |= UpdateNodeType(MVT::isVoid, TP);
+    assert (getNumChildren() >= 2 && "Missing RHS of a set?");
+    unsigned NC = getNumChildren();
+    bool MadeChange = false;
+    for (unsigned i = 0; i < NC-1; ++i) {
+      MadeChange = getChild(i)->ApplyTypeConstraints(TP, NotRegisters);
+      MadeChange |= getChild(NC-1)->ApplyTypeConstraints(TP, NotRegisters);
+    
+      // Types of operands must match.
+      MadeChange |= getChild(i)->UpdateNodeType(getChild(NC-1)->getExtTypes(),
+                                                TP);
+      MadeChange |= getChild(NC-1)->UpdateNodeType(getChild(i)->getExtTypes(),
+                                                   TP);
+      MadeChange |= UpdateNodeType(MVT::isVoid, TP);
+    }
     return MadeChange;
   } else if (getOperator() == ISE.get_intrinsic_void_sdnode() ||
              getOperator() == ISE.get_intrinsic_w_chain_sdnode() ||
@@ -1316,6 +1322,7 @@
         I->error("Input " + DI->getDef()->getName() + " must be named!");
       else if (DI && DI->getDef()->isSubClassOf("Register")) 
         InstImpInputs.push_back(DI->getDef());
+        ;
     }
     return false;
   }
@@ -1393,15 +1400,13 @@
   // Otherwise, this is a set, validate and collect instruction results.
   if (Pat->getNumChildren() == 0)
     I->error("set requires operands!");
-  else if (Pat->getNumChildren() & 1)
-    I->error("set requires an even number of operands");
   
   if (Pat->getTransformFn())
     I->error("Cannot specify a transform function on a set node!");
   
   // Check the set destinations.
-  unsigned NumValues = Pat->getNumChildren()/2;
-  for (unsigned i = 0; i != NumValues; ++i) {
+  unsigned NumDests = Pat->getNumChildren()-1;
+  for (unsigned i = 0; i != NumDests; ++i) {
     TreePatternNode *Dest = Pat->getChild(i);
     if (!Dest->isLeaf())
       I->error("set destination should be a register!");
@@ -1419,15 +1424,16 @@
       InstResults[Dest->getName()] = Dest;
     } else if (Val->getDef()->isSubClassOf("Register")) {
       InstImpResults.push_back(Val->getDef());
+      ;
     } else {
       I->error("set destination should be a register!");
     }
-    
-    // Verify and collect info from the computation.
-    FindPatternInputsAndOutputs(I, Pat->getChild(i+NumValues),
-                                InstInputs, InstResults,
-                                InstImpInputs, InstImpResults);
   }
+    
+  // Verify and collect info from the computation.
+  FindPatternInputsAndOutputs(I, Pat->getChild(NumDests),
+                              InstInputs, InstResults,
+                              InstImpInputs, InstImpResults);
 }
 
 /// ParseInstructions - Parse all of the instructions, inlining and resolving
@@ -1644,10 +1650,7 @@
     TreePatternNode *Pattern = I->getTree(0);
     TreePatternNode *SrcPattern;
     if (Pattern->getOperator()->getName() == "set") {
-      if (Pattern->getNumChildren() != 2)
-        continue;  // Not a set of a single value (not handled so far)
-
-      SrcPattern = Pattern->getChild(1)->clone();    
+      SrcPattern = Pattern->getChild(Pattern->getNumChildren()-1)->clone();
     } else{
       // Not a set (store or something?)
       SrcPattern = Pattern;
@@ -2759,7 +2762,7 @@
         isRoot ? (InstPat ? InstPat->getOnlyTree() : Pattern)
                : (InstPat ? InstPat->getOnlyTree() : NULL);
       if (InstPatNode && InstPatNode->getOperator()->getName() == "set") {
-        InstPatNode = InstPatNode->getChild(1);
+        InstPatNode = InstPatNode->getChild(InstPatNode->getNumChildren()-1);
       }
       bool HasVarOps     = isRoot && II.hasVariableNumberOfOperands;
       bool HasImpInputs  = isRoot && Inst.getNumImpOperands() > 0;





More information about the llvm-commits mailing list