[llvm-commits] [llvm] r40988 - /llvm/trunk/test/Scripts/count

[Reid Spencer]

On Fri, 2007-08-10 at 08:24 -0700, Chris Lattner wrote:
> On Aug 10, 2007, at 8:07 AM, Dan Gohman wrote:
> 
> > URL: http://llvm.org/viewvc/llvm-project?rev=40988&view=rev
> > Log:
> > Add a test script for counting lines. This can be used instead of the
> > "| grep foo | wc -l | grep 2" idiom used by many tests, so that, for
> > example, tests don't mistakenly accept a count of 12 when 2 is
> > expected. Also, the new form is more consice: "| grep foo | count 2".
> 
> Nifty.  Please convert tests that use "wc -l" to use this instead so  
> the suite is consistent.  Thanks Dan,

Why not make the script do the grep too? Something like:

countgrep foo 2

Reid.

> 
> -Chris
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits