[llvm-commits] [llvm] r40641 - /llvm/trunk/lib/Transforms/Scalar/LoopStrengthReduce.cpp

[Chris Lattner]

On Aug 2, 2007, at 2:28 PM, Dan Gohman wrote:

>>> Use SCEVExpander::InsertCastOfTo instead of calling new IntToPtrInst
>>> directly, because the insert point used by the SCEVExpander may vary
>>> from what LSR originally computes.
>>
>> Did this cause a bug?  If so, can you please commit a regtest?   
>> Thanks,
>
> So far I've only seen the problem in the tree where I'm working on
> the attached patch

Ok, then don't worry about it.  Unless you just want to commit the  
test to make sure it never regresses in the future.

> , which moves the getelementptr logic out of LSR into
> SCEV, and generalizes it to handle more pointer expressions.

Interesting approach.  Does this impact the -indvars pass at all?

-Chris