[llvm-commits] Patch for LangRef.html as part of Atomic Operations

Reid Spencer rspencer at reidspencer.com
Fri Jul 20 10:50:44 PDT 2007


On Fri, 2007-07-20 at 10:44 -0500, Dan Gohman wrote:
> >> +<div class="doc_subsubsection">
> >> +  <a name="atomic_membarrier">'<tt>llvm.atomic.membarrier</tt>'
> >> Intrinsic</a>
> >
> > Consider naming this llvm.atomic.memory.barrier ?
> 
> I know I said earlier that I liked the "atomic" in the names, but
> for membarrier it's a little confusing, since the operation
> is relevent for all memory operations, not just the "atomic" ones.
> 
> How about llvm.membarrier, or llvm.memory.barrier if you like
> Reid's proposed convention?

Yeah, I was thinking the same thing. It doesn't read well. I put
"atomic" in there just for grouping with the other related intrinsics.
But, its probably better to get an accurate name. I'm fine with dropping
the atomic part.

Reid.

> 
> Dan
> 




More information about the llvm-commits mailing list