[llvm-commits] [llvm] r40069 - in /llvm/trunk: docs/ lib/AsmParser/ lib/VMCore/ test/ test/Assembler/ test/CFrontend/ test/CodeGen/ARM/ test/CodeGen/Alpha/ test/CodeGen/PowerPC/ test/CodeGen/X86/ test/Feature/ test/Integer/ test/Transforms/GVNPRE/ test/Transforms/GlobalOpt/ test/Transforms/IndVarsSimplify/

[Reid Spencer]

On Thu, 2007-07-19 at 20:32 -0700, Chris Lattner wrote:
> On Jul 19, 2007, at 4:13 PM, Reid Spencer wrote:
> 
> > Author: reid
> > Date: Thu Jul 19 18:13:04 2007
> > New Revision: 40069
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=40069&view=rev
> > Log:
> > For PR1553:
> > Change the keywords for the zext and sext parameter attributes to be
> > zeroext and signext so they don't conflict with the keywords for the
> > instructions of the same name. This gets around the ambiguity.
> 
> Thanks Reid!
> 
> Shouldn't the .ll parser autoupgrade llvm 2.0 .ll files?

There isn't a good way to do it and still fix PR1553. That is, I'd have
to reinstate the zext and sext keywords as parameter attributes so that
the ambiguity between a function level zext/sext and a sext/zext
instruction would remain.

We should probably provide a -2.0 switch to llvm-upgrade and have it
read 2.0 assembly and upgrade to 2.x versions. Keeping it fresh for each
2.x release. However, that means duplicating the .y and .l files and a
lot of mucking around. I figured it would be better to fix the bug and
then deal with the upgrade thing closer to release. I really don't have
2 weeks of time to work on this right now.

Reid.

> -Chris
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits