[llvm-commits] [llvm] r39967 - in /llvm/trunk: lib/Target/X86/X86MachineFunctionInfo.h lib/Target/X86/X86RegisterInfo.cpp lib/Target/X86/X86RegisterInfo.h test/CodeGen/X86/2006-05-02-InstrSched2.ll test/CodeGen/X86/2006-05-11-InstrSched.ll test/CodeGen/X86/2007-03-15-GEP-Idx-Sink.ll test/CodeGen/X86/2007-05-07-InvokeSRet.ll

[Evan Cheng]

On Jul 17, 2007, at 7:59 AM, Dan Gohman wrote:

>> Use push / pop for prologues and epilogues.
>
> Cool!
>
>> +  if (NumBytes) {    // adjust stack pointer back: ESP += numbytes
>
> It looks like this doesn't reset ESP/RSP in the case where a  
> function calls
> alloca but has no static-sized allocation, i.e. when NumBytes is zero
> and MFI->hasVarSizedObjects() is true.

Right. Fixed. Somehow it didn't break anything on x86 / Mac OS X. Do  
you have a failure case? If so, please reduce it and send it  to me  
if possible?

Thanks,

Evan

>
> Dan
>
> -- 
> Dan Gohman, Cray Inc.
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits