[llvm-commits] Committing SVN Style

[Reid Spencer]

To All Committers:

In reviewing the llvm-commits list, I'm noticing that some of you are
utilizing SVN as if it was CVS .. committing one file or one directory
at a time. Personally, I would like to see us commit
atomic/incremental/related change sets across all directories in a
sub-project as a single commit.  That is, if you're going to check in a
bunch of changes for a single purpose then do them all in one shot, not
one commit for each directory or file involved. 

Going forward this will really help as ViewVC can show us a revision,
list all the files affected and that constitutes a single change
(related group of changes for a single purpose). We can also just refer
to a rev # in bugzilla and the change set is clear.

For some examples:

Right Way:
http://llvm.org/viewvc/llvm-project?view=revision&revision=37926
This is a nice incremental commit: "initial JIT support for ARM"

Wrong Way:
http://llvm.org/viewvc/llvm-project?rev=37915&view=rev
http://llvm.org/viewvc/llvm-project?rev=37914&view=rev 
These two commits are "unbreak the build". One fixes the ARM backend to
compile. The other enables building the ARM backend in the makefile.
Logically, this is one change set and the commits should reflect that.

While I've picked on Evan here for examples, he's not the only one doing
it and he doesn't always do it (as evidenced above). 

Thanks,

Reid.