[llvm-commits] CVS: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp LegalizeDAG.cpp SelectionDAG.cpp SelectionDAGISel.cpp TargetLowering.cpp

Dan Gohman djg at cray.com
Fri Jun 29 12:38:33 PDT 2007


>> Just as there isn't a special ADD node kind for vectors -- just an ADD
>> kind with nodes that can have a vector ValueType, ConstantFP can also
>> be "vectorized". A ConstantFP with a vector ValueType is a vector  
>> constant,
>> equivalent to what is currently represented as a splat BUILD_VECTOR,
>> except that it's easier to work with :).
> 
> I'm not opposed to doing this, but I don't think we should overload  
> ConstantFP() and getConstantFP() for this.  Could you make a new  
> VectorConstantFP or something?

We overload ISD::FADD and quite a lot of others. Why not ISD::ConstantFP too?

Dan

-- 
Dan Gohman, Cray Inc.



More information about the llvm-commits mailing list