[llvm-commits] CVS: llvm/lib/CodeGen/BranchFolding.cpp

Dale Johannesen dalej at apple.com
Fri Jun 1 13:28:00 PDT 2007


On Jun 1, 2007, at 1:24 PM, Duncan Sands wrote:
> Suppose a successor S1 has isLandingPad true because it is
> a landing pad for some other MBB, and some later successor (S2)
> has isLandingPad true because it is the landing pad for this
> MBB.  What will happen?  When we get to S1 foundPad is set to
> true and S1 is not deleted.  Later we get to S2 and, because
> foundPad is true, fall through to
>     } else {
>       // Otherwise, this is a superfluous edge, remove it.
>       MBB.removeSuccessor(SI);
>       MadeChange = true;
>     }
> and wrongly delete S2.

Good catch, thanks.  I'll fix that.





More information about the llvm-commits mailing list