[llvm-commits] Use of MVT::LAST_VECTOR_VALUETYPE in PowerPC target

Chris Lattner clattner at apple.com
Fri May 18 15:47:08 PDT 2007


On May 18, 2007, at 2:51 PM, Dan Gohman wrote:

> On May 18, 2007, at 3:08 PM, Chris Lattner wrote:
>>
>>> Hello all,
>>>
>>> While doing some experiments with vector ValueTypes, I noticed that
>>> the PowerPC target uses MVT::LAST_VECTOR_VALUETYPE inconsistently  
>>> with
>>> the way it is declared. I don't have the resources to test PowerPC
>>> changes, so I'm just sending this patch to the list in case anyone
>>> who does is interested in it.
>>
>> The patch looks safe to me, but how is it semantically different?
>
> It would make the for loop cover v2f64, where it didn't before.

Ah, I get it.  LAST_VECTOR_VT is inclusive, not exclusive.  The patch  
looks great, plz apply,

Thanks,

-Chris 



More information about the llvm-commits mailing list