[llvm-commits] CVS: llvm/lib/Support/MemoryBuffer.cpp

[Chris Lattner]

On May 6, 2007, at 12:50 AM, Reid Spencer wrote:

> On Sun, 2007-05-06 at 00:43 -0700, Chris Lattner wrote:
>>>> +  MemoryBufferMMapFile() {}
>>>> +
>>>> +  bool open(const sys::Path &Filename);
>>>
>>> Shouldn't this have a parameter to receive the error message ?
>>
>> No, because membuffer doesn't know why the open failed.  It would
>> always return the same thing.
>
> It must be passed up from lib/System. I suggested this in my other
> comments on these changes.
>
> It is not acceptable to force the application to print something like:
>
> "file: can't open: don't know why, we just can't"
>
> (I'm exaggerating but you get the point)

Ah, I didn't realize mapped file did this.  This is great, I'll do  
this after my current set of changes.  It will simplify several clients.

-Chris