[llvm-commits] CVS: llvm/test/CodeGen/X86/ispositive.ll

[Reid Spencer]

On Sun, 29 Apr 2007 22:29:17 -0700
 Chris Lattner <clattner at apple.com> wrote:
>
>Reid, why are you duplicating these tests?

Because they need to be. Such tests will cause false regressions if LLVM is not built with support for all the targets used in the test case. Duplicating them into the various target sub-directories (instead of in the Generic directory) eliminates the "false positives" when fewer targets are built. Please see PR1370 for a more complete description.  If you still have a problem with this, call me on my cell phone to discuss.

>
>-Chris
>
>On Apr 29, 2007, at 10:12 PM, Reid Spencer wrote:
>
>>
>>
>> Changes in directory llvm/test/CodeGen/X86:
>>
>> ispositive.ll added (r1.1)
>> ---
>> Log message:
>>
>> For PR1370: http://llvm.org/PR1370 :
>> Rearrange some tests so that if PowerPC is not being built we don't  
>> try to
>> run PowerPC specific tests.
>>
>>
>> ---
>> Diffs of the changes:  (+9 -0)
>>
>>  ispositive.ll |    9 +++++++++
>>  1 files changed, 9 insertions(+)
>>
>>
>> Index: llvm/test/CodeGen/X86/ispositive.ll
>> diff -c /dev/null llvm/test/CodeGen/X86/ispositive.ll:1.1
>> *** /dev/null	Mon Apr 30 00:12:08 2007
>> --- llvm/test/CodeGen/X86/ispositive.ll	Mon Apr 30 00:11:58 2007
>> ***************
>> *** 0 ****
>> --- 1,9 ----
>> + ; RUN: llvm-as < %s | llc -march=x86 | grep {shrl.*31}
>> +
>> + define i32 @test1(i32 %X) {
>> + entry:
>> +         icmp slt i32 %X, 0              ; <i1>:0 [#uses=1]
>> +         zext i1 %0 to i32               ; <i32>:1 [#uses=1]
>> +         ret i32 %1
>> + }
>> +
>>
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>_______________________________________________
>llvm-commits mailing list
>llvm-commits at cs.uiuc.edu
>http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits