[llvm-commits] CVS: llvm-test/MultiSource/Benchmarks/Olden/voronoi/newvor.c

Jeff Cohen jeffc at jolt-lang.org
Thu Apr 26 14:32:24 PDT 2007


Chris Lattner wrote:
>
> On Apr 26, 2007, at 2:23 PM, Jeff Cohen wrote:
>
>> Chris Lattner wrote:
>>>
>>> On Apr 26, 2007, at 1:11 PM, Jeff Cohen wrote:
>>>
>>>> Absolutely true.  This change will cause the test to fail on the BSDs,
>>>> which will complain that malloc.h has been replaced by stdlib.h.  
>>>> Please
>>>> use a different test.
>>>
>>> Better yet, just unconditionally #include <stdlib.h> and eliminate 
>>> <malloc.h>
>>>
>>> -Chris
>>
>> It already does include stdlib.h.  I assume it isn't enough on his 
>> system.
>
> Andrew, can alpha drop the malloc.h #include?  If not, why not?
>
> We should remove all instances of malloc.h from llvm-test.
>
> -Chris

A more interesting question is why he needed to add it for x86_64.  If 
Linux doesn't need it for x86, it shouldn't need it for x86_64 either.




More information about the llvm-commits mailing list