[llvm-commits] Patch resubmit: ROTL/ROTR cleanups

Chris Lattner clattner at apple.com
Mon Apr 2 15:10:00 PDT 2007


On Apr 2, 2007, at 2:44 PM, Scott Michel wrote:

> On Apr 2, 2007, at 1:11 PM, Chris Lattner wrote:
>
>> On Mar 30, 2007, at 12:02 PM, Scott Michel wrote:
>>> Spotted what was probably a long-standing bug, since some of my
>>> cleanups
>>> were simple substitutions.
>>
>> Sorry for the delay.  In general, if you keep the changes as simple
>> and disjoint as possible, I'm more likely to look at them soon :).
>> Here you could split up the "allow custom legalize of rotates" part
>> from the "introduce some temporary vars" part from "match ext
>> rotate cases" part.
>
> I did, I did, I did! Really! They're part and parcel of the same
> functionality... :-)

:)

>> Likewise.
>
> Fixed tab violations, which made it look like incorrect indentation...

Great, even better!

-Chris



More information about the llvm-commits mailing list