[llvm-commits] CVS: llvm/lib/AsmParser/llvmAsmParser.y

Reid Spencer reid at x10sys.com
Mon Feb 5 09:01:36 PST 2007



Changes in directory llvm/lib/AsmParser:

llvmAsmParser.y updated: 1.318 -> 1.319
---
Log message:

! removal was a little over zealous. Put the ! back in asserts.


---
Diffs of the changes:  (+9 -9)

 llvmAsmParser.y |   18 +++++++++---------
 1 files changed, 9 insertions(+), 9 deletions(-)


Index: llvm/lib/AsmParser/llvmAsmParser.y
diff -u llvm/lib/AsmParser/llvmAsmParser.y:1.318 llvm/lib/AsmParser/llvmAsmParser.y:1.319
--- llvm/lib/AsmParser/llvmAsmParser.y:1.318	Mon Feb  5 04:16:10 2007
+++ llvm/lib/AsmParser/llvmAsmParser.y	Mon Feb  5 11:01:20 2007
@@ -429,11 +429,11 @@
     return IA;
   }
   default:
-    assert(0 && "Unhandled case");
+    assert(0 && "Unhandled case!");
     return 0;
   }   // End of switch
 
-  assert(0 && "Unhandled case");
+  assert(0 && "Unhandled case!");
   return 0;
 }
 
@@ -484,7 +484,7 @@
 ///    or may not be a forward reference.
 ///
 static BasicBlock *getBBVal(const ValID &ID, bool isDefinition = false) {
-  assert(inFunctionScope() && "Can't get basic block at global scope");
+  assert(inFunctionScope() && "Can't get basic block at global scope!");
 
   std::string Name;
   BasicBlock *BB = 0;
@@ -573,7 +573,7 @@
 
       std::map<Value*, std::pair<ValID, int> >::iterator PHI =
         CurModule.PlaceHolderInfo.find(V);
-      assert(PHI != CurModule.PlaceHolderInfo.end() && "Placeholder error");
+      assert(PHI != CurModule.PlaceHolderInfo.end() && "Placeholder error!");
 
       ValID &DID = PHI->second.first;
 
@@ -639,7 +639,7 @@
     return;
   }
 
-  assert(inFunctionScope() && "Must be in function scope");
+  assert(inFunctionScope() && "Must be in function scope!");
   SymbolTable &ST = CurFun.CurrentFunction->getValueSymbolTable();
   if (ST.lookup(V->getType(), Name)) {
     GenerateError("Redefinition of value '" + Name + "' of type '" +
@@ -724,7 +724,7 @@
 // allowed to be redefined in the specified context.  If the name is a new name
 // for the type plane, it is inserted and false is returned.
 static bool setTypeName(const Type *T, char *NameStr) {
-  assert(!inFunctionScope() && "Can't give types function-local names");
+  assert(!inFunctionScope() && "Can't give types function-local names!");
   if (NameStr == 0) return false;
  
   std::string Name(NameStr);      // Copy string
@@ -741,7 +741,7 @@
 
   if (AlreadyExists) {   // Inserting a name that is already defined???
     const Type *Existing = CurModule.CurrentModule->getTypeByName(Name);
-    assert(Existing && "Conflict but no matching type?");
+    assert(Existing && "Conflict but no matching type?!");
 
     // There is only one case where this is allowed: when we are refining an
     // opaque type.  In this case, Existing will be an opaque type.
@@ -1625,7 +1625,7 @@
     // in the future with the right type of variable.
     //
     if (V == 0) {
-      assert(isa<PointerType>(Ty) && "Globals may only be used as pointers");
+      assert(isa<PointerType>(Ty) && "Globals may only be used as pointers!");
       const PointerType *PT = cast<PointerType>(Ty);
 
       // First check to see if the forward references value is already created!
@@ -2116,7 +2116,7 @@
   if ($5) {                     // Is null if empty...
     if (isVarArg) {  // Nuke the last entry
       assert($5->back().Ty->get() == Type::VoidTy && $5->back().Name == 0&&
-             "Not a varargs marker");
+             "Not a varargs marker!");
       delete $5->back().Ty;
       $5->pop_back();  // Delete the last entry
     }






More information about the llvm-commits mailing list