[llvm-commits] [PATCH] PR970: isFloatingPoint audit 5 of 5

[Gordon Henriksen]

This final patch simplifies the logic in SelectionDAGISel.cpp with no  
functional change. This construct was in use:

     if (I.getType()->isFloatingPoint())
       visitFPBinary(I, ISD::FADD, ISD::VADD);
     else
       visitIntBinary(I, ISD::ADD, ISD::VADD);

Which confusingly sent even floating-point vector operations through  
the visitIntBinary routine. However, this was not a bug because  
visitFPBinary and visitIntBinary were identical (as is the vector  
opcode parameter).

This patch streamlines the logic and eliminates redundant methods.

— Gordon



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20070120/db2756ae/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pr970-5.patch
Type: application/octet-stream
Size: 6402 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20070120/db2756ae/attachment.obj>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20070120/db2756ae/attachment-0001.html>