[llvm-commits] CVS: llvm/test/Makefile

Reid Spencer reid at x10sys.com
Thu Apr 13 13:34:12 PDT 2006



Changes in directory llvm/test:

Makefile updated: 1.86 -> 1.87
---
Log message:

Use quotes properly so that the possibility of a null variable set is
eliminated. This can happen, for example, if LLVM is configured without 
llvm-gcc in which case things like LLVMGCC_VERSION will be empty. In
such cases, deja-gnu fails with:
can't read "llvmgcc_version": no such variable
because it sees:
set llvmgcc_version
instead of:
set llvmgcc_version ""


---
Diffs of the changes:  (+4 -4)

 Makefile |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)


Index: llvm/test/Makefile
diff -u llvm/test/Makefile:1.86 llvm/test/Makefile:1.87
--- llvm/test/Makefile:1.86	Wed Apr 12 13:08:25 2006
+++ llvm/test/Makefile	Thu Apr 13 15:33:59 2006
@@ -40,11 +40,11 @@
 	@echo '## these variables are automatically generated by make ##' >site.tmp
 	@echo '# Do not edit here.  If you wish to override these values' >>site.tmp
 	@echo '# edit the last section' >>site.tmp
-	@echo "set target_triplet $(TARGET_TRIPLE)" >> site.tmp
-	@echo "set llvmgcc_version $(LLVMGCC_VERSION)" >> site.tmp
+	@echo 'set target_triplet "$(TARGET_TRIPLE)"' >> site.tmp
+	@echo 'set llvmgcc_version "$(LLVMGCC_VERSION)"' >> site.tmp
 	@echo 'set prcontext "$(TCLSH) $(LLVM_SRC_ROOT)/test/Scripts/prcontext.tcl"' >> site.tmp
-	@echo 'set srcdir $(LLVM_SRC_ROOT)/test' >>site.tmp
-	@echo "set objdir $(LLVM_OBJ_ROOT)/test" >>site.tmp
+	@echo 'set srcdir "$(LLVM_SRC_ROOT)/test"' >>site.tmp
+	@echo 'set objdir "$(LLVM_OBJ_ROOT)/test"' >>site.tmp
 	@echo 'set llvmgcc "PATH=\"$(LLVMToolDir):$(PATH)\" \"$(LLVMGCC)\""' >> site.tmp
 	@echo 'set llvmgxx "PATH=\"$(LLVMToolDir):$(PATH)\" \"$(LLVMGCC)\""' >> site.tmp
 	@echo 'set llvmgccmajvers "$(LLVMGCC_MAJVERS)"' >> site.tmp






More information about the llvm-commits mailing list