[llvm-commits] CVS: llvm/lib/VMCore/Verifier.cpp

[Chris Lattner]

Changes in directory llvm/lib/VMCore:

Verifier.cpp updated: 1.153 -> 1.154
---
Log message:

Use the isValidOperands helper instead of duplicating checking code


---
Diffs of the changes:  (+7 -16)

 Verifier.cpp |   23 +++++++----------------
 1 files changed, 7 insertions(+), 16 deletions(-)


Index: llvm/lib/VMCore/Verifier.cpp
diff -u llvm/lib/VMCore/Verifier.cpp:1.153 llvm/lib/VMCore/Verifier.cpp:1.154
--- llvm/lib/VMCore/Verifier.cpp:1.153	Fri Apr  7 20:18:18 2006
+++ llvm/lib/VMCore/Verifier.cpp	Fri Apr  7 23:07:52 2006
@@ -540,26 +540,17 @@
 }
 
 void Verifier::visitExtractElementInst(ExtractElementInst &EI) {
-  Assert1(isa<PackedType>(EI.getOperand(0)->getType()),
-          "First operand to extractelement must be packed type!", &EI);
-  Assert1(EI.getOperand(1)->getType() == Type::UIntTy,
-          "Second operand to extractelement must be uint type!", &EI);
-  Assert1(EI.getType() == 
-          cast<PackedType>(EI.getOperand(0)->getType())->getElementType(),
-          "Extractelement return type must match "
-          "first operand element type!", &EI);
+  Assert1(ExtractElementInst::isValidOperands(EI.getOperand(0),
+                                              EI.getOperand(1)),
+          "Invalid extractelement operands!", &EI);
   visitInstruction(EI);
 }
 
 void Verifier::visitInsertElementInst(InsertElementInst &IE) {
-  Assert1(isa<PackedType>(IE.getOperand(0)->getType()),
-          "First operand to insertelement must be packed type!", &IE);
-  Assert1(IE.getOperand(1)->getType() == 
-          cast<PackedType>(IE.getOperand(0)->getType())->getElementType(),
-          "Second operand to insertelement must match "
-          "first operand element type!", &IE);
-  Assert1(IE.getOperand(2)->getType() == Type::UIntTy,
-          "Third operand to insertelement must be uint type!", &IE);
+  Assert1(InsertElementInst::isValidOperands(IE.getOperand(0),
+                                             IE.getOperand(1),
+                                             IE.getOperand(2)),
+          "Invalid insertelement operands!", &IE);
   visitInstruction(IE);
 }