[llvm-commits] CVS: llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp

[Chris Lattner]

Changes in directory llvm/lib/CodeGen/SelectionDAG:

LegalizeDAG.cpp updated: 1.183 -> 1.184
---
Log message:

Fix a bug in legalize where it would emit two calls to libcalls that return
i64 values on targets that need that expanded to 32-bit registers.  This fixes
PowerPC/2005-09-02-LegalizeDuplicatesCalls.ll and speeds up 189.lucas from
taking 122.72s to 81.96s on my desktop.



---
Diffs of the changes:  (+13 -10)

 LegalizeDAG.cpp |   23 +++++++++++++----------
 1 files changed, 13 insertions(+), 10 deletions(-)


Index: llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp
diff -u llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:1.183 llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:1.184
--- llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:1.183	Thu Sep  1 20:15:01 2005
+++ llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp	Fri Sep  2 15:26:58 2005
@@ -1996,7 +1996,7 @@
   SDOperand Result;
   SDNode *Node = Op.Val;
 
-  if (!Node->hasOneUse()) {
+  if (1 || !Node->hasOneUse()) {
     std::map<SDOperand, SDOperand>::iterator I = PromotedNodes.find(Op);
     if (I != PromotedNodes.end()) return I->second;
   } else {
@@ -2709,21 +2709,24 @@
   std::pair<SDOperand,SDOperand> CallInfo =
     TLI.LowerCallTo(InChain, RetTy, false, CallingConv::C, false,
                     Callee, Args, DAG);
-  SpliceCallInto(CallInfo.second, OutChain);
-
-  NeedsAnotherIteration = true;
 
+  SDOperand Result;
   switch (getTypeAction(CallInfo.first.getValueType())) {
   default: assert(0 && "Unknown thing");
   case Legal:
-    return CallInfo.first;
+    Result = CallInfo.first;
+    break;
   case Promote:
     assert(0 && "Cannot promote this yet!");
   case Expand:
-    SDOperand Lo;
-    ExpandOp(CallInfo.first, Lo, Hi);
-    return Lo;
+    ExpandOp(CallInfo.first, Result, Hi);
+    CallInfo.second = LegalizeOp(CallInfo.second);
+    break;
   }
+  
+  SpliceCallInto(CallInfo.second, OutChain);
+  NeedsAnotherIteration = true;
+  return Result;
 }
 
 
@@ -2845,7 +2848,7 @@
   // If there is more than one use of this, see if we already expanded it.
   // There is no use remembering values that only have a single use, as the map
   // entries will never be reused.
-  if (!Node->hasOneUse()) {
+  if (1 || !Node->hasOneUse()) {
     std::map<SDOperand, std::pair<SDOperand, SDOperand> >::iterator I
       = ExpandedNodes.find(Op);
     if (I != ExpandedNodes.end()) {
@@ -3259,7 +3262,7 @@
   }
 
   // Remember in a map if the values will be reused later.
-  if (!Node->hasOneUse()) {
+  if (1 || !Node->hasOneUse()) {
     bool isNew = ExpandedNodes.insert(std::make_pair(Op,
                                             std::make_pair(Lo, Hi))).second;
     assert(isNew && "Value already expanded?!?");