[llvm-commits] CVS: llvm/include/llvm/CodeGen/LiveVariables.h
Chris Lattner
lattner at cs.uiuc.edu
Tue Aug 23 16:40:52 PDT 2005
Changes in directory llvm/include/llvm/CodeGen:
LiveVariables.h updated: 1.23 -> 1.24
---
Log message:
Change live variables from using multimaps to using maps of vectors and
rearrange some of the accessors to be more efficient.
This makes it much more efficient to iterate over all of the things with the
same value. This speeds up liveintervals analysis from 8.63s to 3.79s with
a release build of llc on kc++ with -march=ia64. This also speeds up live
var from 1.66s -> 0.87s as well, reducing total llc time from 20.1s->15.2s.
This also speeds up other targets slightly, e.g. llc time on X86 from 16.84
-> 16.45s, and PPC from 17.64->17.03s.
---
Diffs of the changes: (+62 -46)
LiveVariables.h | 108 ++++++++++++++++++++++++++++++++------------------------
1 files changed, 62 insertions(+), 46 deletions(-)
Index: llvm/include/llvm/CodeGen/LiveVariables.h
diff -u llvm/include/llvm/CodeGen/LiveVariables.h:1.23 llvm/include/llvm/CodeGen/LiveVariables.h:1.24
--- llvm/include/llvm/CodeGen/LiveVariables.h:1.23 Tue Aug 23 17:43:24 2005
+++ llvm/include/llvm/CodeGen/LiveVariables.h Tue Aug 23 18:40:41 2005
@@ -40,7 +40,8 @@
public:
struct VarInfo {
/// DefInst - The machine instruction that defines this register.
- MachineInstr *DefInst;
+ ///
+ MachineInstr *DefInst;
/// AliveBlocks - Set of blocks of which this value is alive completely
/// through. This is a bit set which uses the basic block number as an
@@ -76,18 +77,22 @@
///
std::vector<VarInfo> VirtRegInfo;
- /// RegistersKilled - This multimap keeps track of all of the registers that
+ /// RegistersKilled - This map keeps track of all of the registers that
/// are dead immediately after an instruction reads its operands. If an
/// instruction does not have an entry in this map, it kills no registers.
///
- std::multimap<MachineInstr*, unsigned> RegistersKilled;
+ std::map<MachineInstr*, std::vector<unsigned> > RegistersKilled;
- /// RegistersDead - This multimap keeps track of all of the registers that are
+ /// RegistersDead - This map keeps track of all of the registers that are
/// dead immediately after an instruction executes, which are not dead after
/// the operands are evaluated. In practice, this only contains registers
/// which are defined by an instruction, but never used.
///
- std::multimap<MachineInstr*, unsigned> RegistersDead;
+ std::map<MachineInstr*, std::vector<unsigned> > RegistersDead;
+
+ /// Dummy - An always empty vector used for instructions without dead or
+ /// killed operands.
+ std::vector<unsigned> Dummy;
/// AllocatablePhysicalRegisters - This vector keeps track of which registers
/// are actually register allocatable by the target machine. We can not track
@@ -110,51 +115,67 @@
/// killed_iterator - Iterate over registers killed by a machine instruction
///
- typedef std::multimap<MachineInstr*, unsigned>::iterator killed_iterator;
+ typedef std::vector<unsigned>::iterator killed_iterator;
+ std::vector<unsigned> &getKillsVector(MachineInstr *MI) {
+ std::map<MachineInstr*, std::vector<unsigned> >::iterator I =
+ RegistersKilled.find(MI);
+ return I != RegistersKilled.end() ? I->second : Dummy;
+ }
+ std::vector<unsigned> &getDeadDefsVector(MachineInstr *MI) {
+ std::map<MachineInstr*, std::vector<unsigned> >::iterator I =
+ RegistersDead.find(MI);
+ return I != RegistersDead.end() ? I->second : Dummy;
+ }
+
+
/// killed_begin/end - Get access to the range of registers killed by a
/// machine instruction.
killed_iterator killed_begin(MachineInstr *MI) {
- return RegistersKilled.lower_bound(MI);
+ return getKillsVector(MI).begin();
}
killed_iterator killed_end(MachineInstr *MI) {
- return RegistersKilled.upper_bound(MI);
+ return getKillsVector(MI).end();
}
std::pair<killed_iterator, killed_iterator>
killed_range(MachineInstr *MI) {
- return RegistersKilled.equal_range(MI);
+ std::vector<unsigned> &V = getKillsVector(MI);
+ return std::make_pair(V.begin(), V.end());
}
/// KillsRegister - Return true if the specified instruction kills the
/// specified register.
bool KillsRegister(MachineInstr *MI, unsigned Reg) const {
- typedef std::multimap<MachineInstr*, unsigned>::const_iterator cki;
- std::pair<cki, cki> KIP = RegistersKilled.equal_range(MI);
- for (; KIP.first != KIP.second; ++KIP.first)
- if (KIP.first->second == Reg)
- return true;
+ std::map<MachineInstr*, std::vector<unsigned> >::const_iterator I =
+ RegistersKilled.find(MI);
+ if (I != RegistersKilled.end())
+ for (std::vector<unsigned>::const_iterator CI = I->second.begin(),
+ E = I->second.end(); CI != E; ++CI)
+ if (*CI == Reg) return true;
return false;
}
killed_iterator dead_begin(MachineInstr *MI) {
- return RegistersDead.lower_bound(MI);
+ return getDeadDefsVector(MI).begin();
}
killed_iterator dead_end(MachineInstr *MI) {
- return RegistersDead.upper_bound(MI);
+ return getDeadDefsVector(MI).end();
}
std::pair<killed_iterator, killed_iterator>
dead_range(MachineInstr *MI) {
- return RegistersDead.equal_range(MI);
+ std::vector<unsigned> &V = getDeadDefsVector(MI);
+ return std::make_pair(V.begin(), V.end());
}
/// RegisterDefIsDead - Return true if the specified instruction defines the
/// specified register, but that definition is dead.
bool RegisterDefIsDead(MachineInstr *MI, unsigned Reg) const {
- typedef std::multimap<MachineInstr*, unsigned>::const_iterator cki;
- std::pair<cki, cki> KIP = RegistersDead.equal_range(MI);
- for (; KIP.first != KIP.second; ++KIP.first)
- if (KIP.first->second == Reg)
- return true;
+ std::map<MachineInstr*, std::vector<unsigned> >::const_iterator I =
+ RegistersDead.find(MI);
+ if (I != RegistersDead.end())
+ for (std::vector<unsigned>::const_iterator CI = I->second.begin(),
+ E = I->second.end(); CI != E; ++CI)
+ if (*CI == Reg) return true;
return false;
}
@@ -185,23 +206,20 @@
MachineInstr *MI) {
if (!getVarInfo(reg).removeKill(MI))
return false;
- for (killed_iterator i = killed_begin(MI), e = killed_end(MI); i != e; ) {
- if (i->second == reg)
- RegistersKilled.erase(i++);
- else
- ++i;
- }
+
+ std::vector<unsigned> &V = getKillsVector(MI);
+ for (unsigned i = 0, e = V.size(); i != e; ++i)
+ if (V[i] == reg) {
+ V.erase(V.begin()+i);
+ return true;
+ }
return true;
}
- /// removeVirtualRegistersKilled - Remove all of the specified killed
- /// registers from the live variable information.
- void removeVirtualRegistersKilled(killed_iterator B, killed_iterator E) {
- for (killed_iterator I = B; I != E; ++I) { // Remove VarInfo entries...
- bool removed = getVarInfo(I->second).removeKill(I->first);
- assert(removed && "kill not in register's VarInfo?");
- }
- RegistersKilled.erase(B, E);
+ /// removeVirtualRegistersKilled - Remove all killed info for the specified
+ /// instruction.
+ void removeVirtualRegistersKilled(MachineInstr *MI) {
+ RegistersKilled.erase(MI);
}
/// addVirtualRegisterDead - Add information about the fact that the specified
@@ -222,21 +240,19 @@
if (!getVarInfo(reg).removeKill(MI))
return false;
- for (killed_iterator i = killed_begin(MI), e = killed_end(MI); i != e; ) {
- if (i->second == reg)
- RegistersKilled.erase(i++);
- else
- ++i;
- }
+ std::vector<unsigned> &V = getDeadDefsVector(MI);
+ for (unsigned i = 0, e = V.size(); i != e; ++i)
+ if (V[i] == reg) {
+ V.erase(V.begin()+i);
+ return true;
+ }
return true;
}
/// removeVirtualRegistersDead - Remove all of the specified dead
/// registers from the live variable information.
- void removeVirtualRegistersDead(killed_iterator B, killed_iterator E) {
- for (killed_iterator I = B; I != E; ++I) // Remove VarInfo entries...
- getVarInfo(I->second).removeKill(I->first);
- RegistersDead.erase(B, E);
+ void removeVirtualRegistersDead(MachineInstr *MI) {
+ RegistersDead.erase(MI);
}
virtual void getAnalysisUsage(AnalysisUsage &AU) const {
More information about the llvm-commits
mailing list