[llvm-commits] CVS: llvm/tools/llc/llc.cpp

[Chris Lattner]

On Wed, 27 Jul 2005, Reid Spencer wrote:

> // GetFileNameRoot - Helper function to get the basename of a filename.
> static inline std::string
> @@ -113,6 +123,25 @@
>     PassManager Passes;
>     Passes.add(new TargetData(TD));
>
> +#ifndef NDEBUG
> +    if(!NoVerify)
> +      Passes.add(createVerifierPass());
> +#endif


Shouldn't the verifier be run AFTER the passes below?  This just verifies 
that the bytecode file isn't corrupt, which isn't super useful since gccld 
verifies it is fine before writing it.

-Chris

> +    // Create a new pass for each one specified on the command line
> +    for (unsigned i = 0; i < LLCPassList.size(); ++i) {
> +      const PassInfo *aPass = LLCPassList[i];
> +
> +      if (aPass->getNormalCtor()) {
> +        Pass *P = aPass->getNormalCtor()();
> +        Passes.add(P);
> +      } else {
> +        std::cerr << argv[0] << ": cannot create pass: "
> +                  << aPass->getPassName() << "\n";
> +      }
> +    }
> +
> +
>     // Figure out where we are going to send the output...
>     std::ostream *Out = 0;
>     if (OutputFilename != "") {
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>

-Chris

-- 
http://nondot.org/sabre/
http://llvm.org/