[llvm-commits] CVS: llvm/test/Feature/varargs_new.ll
alenhar2 at cs.uiuc.edu
Sat Jun 18 22:42:18 PDT 2005
On Sat, 2005-06-18 at 22:17 -0500, Chris Lattner wrote:
> Reid: I think this patch should be reverted. This regression test failing
> indicates a bug in the auto-upgrader for .ll files. Imagine if an old
> LLVM front-end generated this file: now llvm-as would crash on it.
No front end would generate this file. This is not a bug in the upgrade
code but a matter of what to do on illegal/invalid .ll files. The
problem here is using oldstyle vaarg with new style va_start (new style
is va_arg, and must be to disambiguate certain legal constructs).
> Not only is this not acceptable from a backwards compatibility
> perspective, llvm-as should not crash on *any* input.
It already does for similar problems. try defining llvm.va_start as
taking 5 args. Verify will hit an assertion. This is no different than
hitting an arguement number check assertion earlier.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 189 bytes
Desc: This is a digitally signed message part
More information about the llvm-commits