[llvm-commits] CVS: llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp SelectionDAG.cpp

[Chris Lattner]

Changes in directory llvm/lib/CodeGen/SelectionDAG:

LegalizeDAG.cpp updated: 1.106 -> 1.107
SelectionDAG.cpp updated: 1.106 -> 1.107
---
Log message:

Make legalize a bit more efficient, and canonicalize sub X, C -> add X, -C


---
Diffs of the changes:  (+12 -8)

 LegalizeDAG.cpp  |    7 +++++--
 SelectionDAG.cpp |   13 +++++++------
 2 files changed, 12 insertions(+), 8 deletions(-)


Index: llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp
diff -u llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:1.106 llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:1.107
--- llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:1.106	Wed May 11 18:43:56 2005
+++ llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp	Wed May 11 19:17:04 2005
@@ -323,8 +323,11 @@
     Tmp1 = LegalizeOp(Node->getOperand(0));  // Legalize the chain.
     // There is no need to legalize the size argument (Operand #1)
     if (Tmp1 != Node->getOperand(0))
-      Result = DAG.getNode(Node->getOpcode(), MVT::Other, Tmp1,
-                           Node->getOperand(1));
+      Node->setAdjCallChain(Tmp1);
+    // Note that we do not create new ADJCALLSTACK DOWN/UP nodes here.  These
+    // nodes are treated specially and are mutated in place.  This makes the dag
+    // legalization process more efficient and also makes libcall insertion
+    // easier.
     break;
   case ISD::DYNAMIC_STACKALLOC:
     Tmp1 = LegalizeOp(Node->getOperand(0));  // Legalize the chain.


Index: llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
diff -u llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:1.106 llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:1.107
--- llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:1.106	Wed May 11 13:57:39 2005
+++ llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp	Wed May 11 19:17:04 2005
@@ -916,7 +916,7 @@
       break;
     case ISD::SUB:
       if (!C2) return N1;         // sub X, 0 -> X
-      break;
+      return getNode(ISD::ADD, VT, N1, getConstant(-C2, VT));
     case ISD::MUL:
       if (!C2) return N2;         // mul X, 0 -> 0
       if (N2C->isAllOnesValue()) // mul X, -1 -> 0-X
@@ -1194,13 +1194,13 @@
 
   // Memoize this node if possible.
   SDNode *N;
-  if (Opcode != ISD::ADJCALLSTACKDOWN) {
+  if (Opcode != ISD::ADJCALLSTACKDOWN && Opcode != ISD::ADJCALLSTACKUP) {
     SDNode *&BON = BinaryOps[std::make_pair(Opcode, std::make_pair(N1, N2))];
     if (BON) return SDOperand(BON, 0);
 
     BON = N = new SDNode(Opcode, N1, N2);
   } else {
-    N = new SDNode(ISD::ADJCALLSTACKDOWN, N1, N2);
+    N = new SDNode(Opcode, N1, N2);
   }
 
 
@@ -1213,11 +1213,12 @@
   return SDOperand(N, 0);
 }
 
-// setAdjCallChain - This method changes the token chain of an ADJCALLSTACKDOWN
-// node to be the specified operand.
+// setAdjCallChain - This method changes the token chain of an
+// ADJCALLSTACKDOWN/UP node to be the specified operand.
 void SDNode::setAdjCallChain(SDOperand N) {
   assert(N.getValueType() == MVT::Other);
-  assert(getOpcode() == ISD::ADJCALLSTACKDOWN && "Cannot adjust this node!");
+  assert((getOpcode() == ISD::ADJCALLSTACKDOWN ||
+          getOpcode() == ISD::ADJCALLSTACKUP) && "Cannot adjust this node!");
 
   Operands[0].Val->removeUser(this);
   Operands[0] = N;