[llvm-commits] CVS: llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp

[Chris Lattner]

Changes in directory llvm/lib/CodeGen/SelectionDAG:

SelectionDAG.cpp updated: 1.89 -> 1.90
---
Log message:

Improve and elimination.  On PPC, for:

bool %test(int %X) {
        %Y = and int %X, 8
        %Z = setne int %Y, 0
        ret bool %Z
}

we now generate this:

        rlwinm r2, r3, 0, 28, 28
        srwi r3, r2, 3
 
instead of this:

        rlwinm r2, r3, 0, 28, 28
        srwi r2, r2, 3
        rlwinm r3, r2, 0, 31, 31

I'll leave it to Nate to get it down to one instruction. :)

---------------------------------------------------------------------


---
Diffs of the changes:  (+26 -6)

 SelectionDAG.cpp |   32 ++++++++++++++++++++++++++------
 1 files changed, 26 insertions(+), 6 deletions(-)


Index: llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
diff -u llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:1.89 llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:1.90
--- llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:1.89	Thu Apr 21 01:12:41 2005
+++ llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp	Thu Apr 21 01:28:15 2005
@@ -781,7 +781,7 @@
 
   case ISD::AND:
     // (X & C1) & C2 == 0   iff   C1 & C2 == 0.
-    if (ConstantSDNode *AndRHS = dyn_cast<ConstantSDNode>(Op.getOperand(0)))
+    if (ConstantSDNode *AndRHS = dyn_cast<ConstantSDNode>(Op.getOperand(1)))
       return MaskedValueIsZero(Op.getOperand(0),AndRHS->getValue() & Mask, TLI);
 
     // FALL THROUGH
@@ -792,9 +792,23 @@
   case ISD::SELECT:
     return MaskedValueIsZero(Op.getOperand(1), Mask, TLI) &&
            MaskedValueIsZero(Op.getOperand(2), Mask, TLI);
-    
-  // TODO: (shl X, C1) & C2 == 0   iff  (-1 << C1) & C2 == 0
-  // TODO: (ushr X, C1) & C2 == 0   iff  (-1 >> C1) & C2 == 0
+
+  case ISD::SRL:
+    // (ushr X, C1) & C2 == 0   iff  X & (C2 << C1) == 0
+    if (ConstantSDNode *ShAmt = dyn_cast<ConstantSDNode>(Op.getOperand(1))) {
+      uint64_t NewVal = Mask << ShAmt->getValue();
+      SrcBits = MVT::getSizeInBits(Op.getValueType());
+      if (SrcBits != 64) NewVal &= (1ULL << SrcBits)-1;
+      return MaskedValueIsZero(Op.getOperand(0), NewVal, TLI);
+    }
+    return false;
+  case ISD::SHL:
+    // (ushl X, C1) & C2 == 0   iff  X & (C2 >> C1) == 0
+    if (ConstantSDNode *ShAmt = dyn_cast<ConstantSDNode>(Op.getOperand(1))) {
+      uint64_t NewVal = Mask >> ShAmt->getValue();
+      return MaskedValueIsZero(Op.getOperand(0), NewVal, TLI);
+    }
+    return false;
   default: break;
   }
 
@@ -941,8 +955,14 @@
       if (MaskedValueIsZero(N1, C2, TLI))  // X and 0 -> 0
         return getConstant(0, VT);
 
-      if (MaskedValueIsZero(N1, ~C2, TLI))
-        return N1;                // if (X & ~C2) -> 0, the and is redundant
+      {
+        uint64_t NotC2 = ~C2;
+        if (VT != MVT::i64)
+          NotC2 &= (1ULL << MVT::getSizeInBits(VT))-1;
+
+        if (MaskedValueIsZero(N1, NotC2, TLI))
+          return N1;                // if (X & ~C2) -> 0, the and is redundant
+      }
 
       // FIXME: Should add a corresponding version of this for
       // ZERO_EXTEND/SIGN_EXTEND by converting them to an ANY_EXTEND node which