[llvm-commits] CVS: llvm/include/llvm/Instructions.h

[Chris Lattner]

Changes in directory llvm/include/llvm:

Instructions.h updated: 1.12 -> 1.13
---
Log message:

Eliminate the explicit volatile fields in LoadInst and StoreInst.  This shrinks
LoadInst from 60 -> 56 bytes and StoreInst from 76 -> 72 bytes.

Note however, that this doesn't actually save any memory on common systems
where 'malloc' returns 8-byte aligned memory, as the saved space is replaced
by useless alignment padding.  :(


---
Diffs of the changes:  (+11 -12)

 Instructions.h |   23 +++++++++++------------
 1 files changed, 11 insertions(+), 12 deletions(-)


Index: llvm/include/llvm/Instructions.h
diff -u llvm/include/llvm/Instructions.h:1.12 llvm/include/llvm/Instructions.h:1.13
--- llvm/include/llvm/Instructions.h:1.12	Fri Jan 28 18:31:36 2005
+++ llvm/include/llvm/Instructions.h	Fri Feb  4 19:44:18 2005
@@ -167,14 +167,14 @@
 //                                LoadInst Class
 //===----------------------------------------------------------------------===//
 
-/// LoadInst - an instruction for reading from memory 
+/// LoadInst - an instruction for reading from memory.  This uses the
+/// SubclassData field in Value to store whether or not the load is volatile.
 ///
 class LoadInst : public UnaryInstruction {
-  bool Volatile;   // True if this is a volatile load
-
   LoadInst(const LoadInst &LI)
-    : UnaryInstruction(LI.getType(), Load, LI.getOperand(0)),
-      Volatile(LI.isVolatile()) {
+    : UnaryInstruction(LI.getType(), Load, LI.getOperand(0)) {
+    setVolatile(LI.isVolatile());
+    
 #ifndef NDEBUG
     AssertOK();
 #endif
@@ -191,11 +191,11 @@
   /// isVolatile - Return true if this is a load from a volatile memory
   /// location.
   ///
-  bool isVolatile() const { return Volatile; }
+  bool isVolatile() const { return SubclassData; }
 
   /// setVolatile - Specify whether this is a volatile load or not.
   ///
-  void setVolatile(bool V) { Volatile = V; }
+  void setVolatile(bool V) { SubclassData = V; }
 
   virtual LoadInst *clone() const;
 
@@ -224,11 +224,10 @@
 ///
 class StoreInst : public Instruction {
   Use Ops[2];
-  bool Volatile;   // True if this is a volatile store
-  StoreInst(const StoreInst &SI) : Instruction(SI.getType(), Store, Ops, 2),
-                                   Volatile(SI.isVolatile()) {
+  StoreInst(const StoreInst &SI) : Instruction(SI.getType(), Store, Ops, 2) {
     Ops[0].init(SI.Ops[0], this);
     Ops[1].init(SI.Ops[1], this);
+    setVolatile(SI.isVolatile());
 #ifndef NDEBUG
     AssertOK();
 #endif
@@ -245,11 +244,11 @@
   /// isVolatile - Return true if this is a load from a volatile memory
   /// location.
   ///
-  bool isVolatile() const { return Volatile; }
+  bool isVolatile() const { return SubclassData; }
 
   /// setVolatile - Specify whether this is a volatile load or not.
   ///
-  void setVolatile(bool V) { Volatile = V; }
+  void setVolatile(bool V) { SubclassData = V; }
 
   /// Transparently provide more efficient getOperand methods.
   Value *getOperand(unsigned i) const {