[llvm-commits] CVS: llvm/lib/Analysis/DataStructure/GraphChecker.cpp Local.cpp

Chris Lattner lattner at cs.uiuc.edu
Fri Feb 20 17:28:02 PST 2004


Changes in directory llvm/lib/Analysis/DataStructure:

GraphChecker.cpp updated: 1.11 -> 1.12
Local.cpp updated: 1.85 -> 1.86

---
Log message:

Add two missing returns, which caused us to be very pessimistic about the
printf and scanf families!


---
Diffs of the changes:  (+3 -2)

Index: llvm/lib/Analysis/DataStructure/GraphChecker.cpp
diff -u llvm/lib/Analysis/DataStructure/GraphChecker.cpp:1.11 llvm/lib/Analysis/DataStructure/GraphChecker.cpp:1.12
--- llvm/lib/Analysis/DataStructure/GraphChecker.cpp:1.11	Sat Feb  7 17:58:05 2004
+++ llvm/lib/Analysis/DataStructure/GraphChecker.cpp	Fri Feb 20 17:27:09 2004
@@ -12,7 +12,7 @@
 // or not a node is collapsed, etc.  These are the command line arguments that
 // it supports:
 //
-//   --dsgc-dsapass={local,bu,td}     - Specify what flavor of graph to check
+//   --dsgc-dspass={local,bu,td}      - Specify what flavor of graph to check
 //   --dsgc-abort-if-any-collapsed    - Abort if any collapsed nodes are found
 //   --dsgc-abort-if-collapsed=<list> - Abort if a node pointed to by an SSA
 //                                      value with name in <list> is collapsed


Index: llvm/lib/Analysis/DataStructure/Local.cpp
diff -u llvm/lib/Analysis/DataStructure/Local.cpp:1.85 llvm/lib/Analysis/DataStructure/Local.cpp:1.86
--- llvm/lib/Analysis/DataStructure/Local.cpp:1.85	Fri Feb 20 14:27:11 2004
+++ llvm/lib/Analysis/DataStructure/Local.cpp	Fri Feb 20 17:27:09 2004
@@ -38,7 +38,6 @@
 static cl::opt<bool>
 TrackIntegersAsPointers("dsa-track-integers",
          cl::desc("If this is set, track integers as potential pointers"));
-                        
 
 namespace llvm {
 namespace DS {
@@ -581,6 +580,7 @@
               if (DSNode *N = getValueDest(**AI).getNode())
                 N->setReadMarker();   
           }
+          return;
         } else if (F->getName() == "scanf" || F->getName() == "fscanf" ||
                    F->getName() == "sscanf") {
           CallSite::arg_iterator AI = CS.arg_begin(), E = CS.arg_end();
@@ -612,6 +612,7 @@
               if (DSNode *N = getValueDest(**AI).getNode())
                 N->setModifiedMarker();   
           }
+          return;
         } else if (F->getName() == "strtok") {
           // strtok reads and writes the first argument, returning it.  It reads
           // its second arg.  FIXME: strtok also modifies some hidden static





More information about the llvm-commits mailing list